Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Version value object #12

Merged
merged 6 commits into from
Sep 23, 2024
Merged

Introduce Version value object #12

merged 6 commits into from
Sep 23, 2024

Conversation

OskarStark
Copy link
Contributor

@OskarStark OskarStark commented Sep 22, 2024 •
edited
Loading

No description provided.

@OskarStark OskarStark changed the title Rename method Introduce Model value object Sep 22, 2024
@OskarStark OskarStark marked this pull request as draft September 22, 2024 17:32
OskarStark
OskarStark commented Sep 22, 2024
View reviewed changes
composer.json Show resolved Hide resolved
src/Anthropic/Model/Claude.php Outdated Show resolved Hide resolved
src/Anthropic/Model/Model.php Outdated Show resolved Hide resolved
src/OpenAI/Model/Model.php Outdated Show resolved Hide resolved
@OskarStark OskarStark changed the title Introduce Model value object Introduce Version value object Sep 23, 2024
@OskarStark OskarStark marked this pull request as ready for review September 23, 2024 16:21
@OskarStark
Copy link
Contributor Author

WDYT @chr-hertel ?

chr-hertel
chr-hertel reviewed Sep 23, 2024
View reviewed changes
composer.lock Outdated Show resolved Hide resolved
@chr-hertel
Copy link
Member

WDYT @chr-hertel ?

yes, looks pretty good to me :)

chr-hertel
chr-hertel approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@chr-hertel chr-hertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, thanks! 🙏

@chr-hertel chr-hertel merged commit 14a9f1a into php-llm:main Sep 23, 2024
4 checks passed
@OskarStark OskarStark deleted the feature/version-vo branch September 23, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chr-hertel chr-hertel chr-hertel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OskarStark @chr-hertel